Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Bump actions/upload-pages-artifact from 1 to 2 #489

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 11, 2023

Bumps actions/upload-pages-artifact from 1 to 2.

Release notes

Sourced from actions/upload-pages-artifact's releases.

v2.0.0

Changelog

See details of all code changes since previous release.

v1.0.10

Changelog

See details of all code changes since previous release.

v1.0.9

Removed chmod as we moved towards trusting correct file permissions have been set. In the event this isn't the case then we raise an error in the action related to the file permissions.

v1.0.8

Changelog

See details of all code changes since previous release.

v1.0.7

Changelog

See details of all code changes since previous release.

v1.0.6

Changelog

See details of all code changes since previous release.

v1.0.5

Changelog

... (truncated)

Commits
  • a753861 Merge pull request #69 from actions/reapply-chmod-removal-for-v2
  • dca6bac Merge branch 'main' into reapply-chmod-removal-for-v2
  • 3138c05 Merge pull request #70 from actions/v2-docs-improvements
  • 07f501f Update README for v2
  • 9c071e6 Reapply PR #63 for v2
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@jrfnl jrfnl added this to the 1.0.x Next milestone Jul 11, 2023
@jrfnl
Copy link
Member

jrfnl commented Jul 11, 2023

Build is failing due to something weird going on with Coveralls. Issue has been reported here: lemurheavy/coveralls-public#1721

@jrfnl
Copy link
Member

jrfnl commented Jul 14, 2023

Argh... okay, so Dependabot triggered workflows do not have access to secrets....
Ref: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#responding-to-events

In other words, Dependabot PRs will never pass the required statuses and will always have to be merged bypassing branch protection....

@jrfnl
Copy link
Member

jrfnl commented Jul 15, 2023

I've adjusted the workflow now to one which (hopefully) should get round this issue.

@dependabot rebase

Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 1 to 2.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@v1...v2)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-pages-artifact-2 branch from ad1fe28 to 4d28dca Compare July 15, 2023 11:59
@jrfnl jrfnl enabled auto-merge July 15, 2023 12:04
@jrfnl jrfnl merged commit 2c451f3 into develop Jul 15, 2023
53 checks passed
@jrfnl jrfnl deleted the dependabot/github_actions/actions/upload-pages-artifact-2 branch July 15, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant