BCFile: sync with PHPCS: support namespace operator in type declarations #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n types PR 180 added support for the namespace keyword used as an operator in type declarations to the `FunctionDeclarations::getParameters()` method. Upstream PR 3066 added the same to the PHPCS native `File::getMethodParameters()` method. As that PR has now been merged, this commit syncs the upstream changes into the `BCFile::getMethodParameters()` method, moves the unit tests to the BCFile test class and updates the documentation for the `FunctionDeclarations::getParameters()` method to support the changes as have been merged upstream.
…n types PR 180 added support for the namespace keyword used as an operator in type declarations to the `FunctionDeclarations::getProperties()` method and by extension the `BCFile::getMethodProperties()` method, even though PHPCS upstream did not support this yet. Upstream PR 3066 added the same to the PHPCS native `File::getMethodProperties()` method. As that PR has now been merged, this commit syncs the upstream changes in, by moving the unit tests from the "Diff" tests to the BCFile tests and annotating that namespace operators in type declarations are now officially supported in the `BCFile::getMethodProperties()` method.
…n types PR 180 added support for the namespace keyword used as an operator in type declarations to the `FunctionDeclarations::getMemberProperties()` method and by extension the `BCFile::getMemberProperties()` method, even though PHPCS upstream did not support this yet. Upstream PR 3066 added the same to the PHPCS native `File::getMemberProperties()` method. As that PR has now been merged, this commit syncs the upstream changes in, by moving the unit tests from the "Diff" tests to the BCFile tests and annotating that namespace operators in type declarations are now officially supported in the `BCFile::getMemberProperties()` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #180 added support for the namespace keyword used as an operator in type declarations to:
FunctionDeclarations::getParameters()method.FunctionDeclarations::getProperties()method and by extension theBCFile::getMethodProperties()method, even though PHPCS upstream did not support this yet.FunctionDeclarations::getMemberProperties()method and by extension theBCFile::getMemberProperties()method, even though PHPCS upstream did not support this yet.Upstream PR #3066 added the same to the PHPCS native
File::getMethodParameters(),File::getMethodProperties()andFile::getMemberProperties()methods.As that PR has now been merged, this commit syncs the upstream changes into the various PHPCSUtils BackCompat methods.
BCFile::getMethodParameters(): sync with PHPCS / namespace operator in types
This commit syncs the upstream changes into the
BCFile::getMethodParameters()method, moves the unit tests to the BCFile test class and updates the documentation for theFunctionDeclarations::getParameters()method to support the changes as have been merged upstream.BCFile::getMethodProperties(): sync with PHPCS / namespace operator in types
This commit syncs the upstream changes in, by moving the unit tests from the "Diff" tests to the BCFile tests and annotating that namespace operators in type declarations are now officially supported in the
BCFile::getMethodProperties()method.BCFile::getMemberProperties(): sync with PHPCS / namespace operator in types
This commit syncs the upstream changes in, by moving the unit tests from the "Diff" tests to the BCFile tests and annotating that namespace operators in type declarations are now officially supported in the
BCFile::getMemberProperties()method.