Operators::isTypeUnion(): BC-fix - namespace operator in return type #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Operators::isTypeUnion()` method is subseptible to the Tokenizer bug which will be fixed in upstream PR 3066 / PHPCS 3.5.7, where the scope opener/closer/condition would not be set for a function declared with a namespace relative return type using the `namespace` keyword as an operator. A work-around has been added to the method now. Includes unit test. Includes minor fix to existing inline documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Operators::isTypeUnion()method is subseptible to the Tokenizer bug which will be fixed in upstream PR #3066 / PHPCS 3.5.7, where the scope opener/closer/condition would not be set for a function declared with a namespace relative return type using thenamespacekeyword as an operator.A work-around has been added to the method now.
Includes unit test.
Includes minor fix to existing inline documentation.