Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: try a work-around for weird Coveralls results #127

Closed

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 20, 2022

The aggregate coverage results reported back by Coveralls for PRs have been off for quite a while now.

While the Coveralls team has not found the root cause yet, they have put an endpoint in place which should help in working around this.

The short of it is that the initial run results get calculated incorrectly, but that a re-run of the same coveralls build gets the correct results for the calculation, so triggering this calculation re-run from within the build should (theoretically) fix the issue.

I am the first to implement this solution though, so consider this a trial for the time being.

Ref:

@jrfnl jrfnl added this to the 1.0.0-alpha4 milestone Sep 20, 2022
@jrfnl jrfnl force-pushed the feature/ghactions-work-around-for-coveralls-reporting branch 2 times, most recently from 5e63daa to 81f739f Compare September 20, 2022 14:43
@jrfnl jrfnl force-pushed the feature/ghactions-work-around-for-coveralls-reporting branch from 81f739f to f274ada Compare December 4, 2022 05:08
@jrfnl jrfnl removed this from the 1.0.0-alpha4 milestone Dec 7, 2022
The aggregate coverage results reported back by Coveralls for PRs have been off for quite a while now.

While the Coveralls team has not found the root cause yet, they have put an endpoint in place which _should_ help in working around this.

The short of it is that the initial run results get calculated incorrectly, but that a re-run of the same coveralls build gets the correct results for the calculation, so triggering this calculation re-run from within the build _should_ (theoretically) fix the issue.

I am the first to implement this solution though, so consider this a trial for the time being.

Ref:
* lemurheavy/coveralls-public#1631
@jrfnl jrfnl force-pushed the feature/ghactions-work-around-for-coveralls-reporting branch from f274ada to 37371d1 Compare December 7, 2022 08:40
@jrfnl jrfnl closed this Jun 17, 2023
@jrfnl jrfnl deleted the feature/ghactions-work-around-for-coveralls-reporting branch November 24, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant