Support PHP 8.1 by moving from opis/closure to laravel/serializable-closure #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤦 I completely forgot we still supported PHP 7.2. Let me try that again… |
|
Hello! Since PHP 7.2 reached EOL over a year ago (2020-11-30), is there a reason to continue supporting it in future PHP-DI versions? Personally, I would be happy to see the minimum req bumped to 7.3 so that the deprecation issue in PHP 8.1 can be addressed. But since I am not involved in the PHP-DI development in any way, I don't know if this (or some other solution) is already on the horizon. Thank you for your time! |
|
Matomo still supports PHP 7.2: #727 (comment) Ideally I'd like to find a solution to still support it (if possible) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #793 with fixed tests and complete removal of opis/closure.