Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from global namespace in fully_qualified_strict_types #8001

Closed

Conversation

Wulfheart
Copy link

No description provided.

@Wirone
Copy link
Member

Wirone commented May 10, 2024

@Wulfheart there is a dedicated global_namespace_import fixer, so this PR won't get merged with only added global namespace support to fully_qualified_strict_types. We plan to merge these fixers, but it requires deprecating both of them and creating new one with proper name (please see here). Are you interested in doing this?

@Wulfheart
Copy link
Author

@Wirone Unfortunately, I am not sure if I have the spare time right now to write a whole new fixer. But I will close this PR and the Discussion I created as I didn't know about the global_namespace_import rule.

@Wulfheart Wulfheart closed this May 10, 2024
@Wirone
Copy link
Member

Wirone commented May 10, 2024

There's no need to write a whole new fixer, but rather:

  • move the current fully_qualified_strict_types's code to the new class and add support for global namespace
  • deprecate both existing rules and configure them as proxy fixers to the new rule

But it's a lot of work anyway, so I understand if you don't want to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants