CI: Allow any integer in PHPStan error for Token's constructor #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different PHP versions have different value for T_STRING, it can't be hardcoded in the ignored error message.
Wirone
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kubawerlos
reviewed
May 9, 2024
| @@ -572,7 +572,7 @@ | |||
| 'path' => __DIR__ . '/../../src/Fixer/PhpUnit/PhpUnitDedicateAssertFixer.php', | |||
| ]; | |||
| $ignoreErrors[] = [ | |||
| 'message' => '#^Parameter \\#1 \\$token of class PhpCsFixer\\\\Tokenizer\\\\Token constructor expects array\\{int, string\\}\\|string, array\\{262, int\\|string\\|true\\} given\\.$#', | |||
| 'message' => '#^Parameter \\#1 \\$token of class PhpCsFixer\\\\Tokenizer\\\\Token constructor expects array\\{int, string\\}\\|string, array\\{[0-9]+, int\\|string\\|true\\} given\\.$#', | |||
There was a problem hiding this comment.
Anyone running composer phpstan:baseline would have this reverted to 262 or, in few hours/days to 313.
There was a problem hiding this comment.
Yeah, you're right, it would make sense only in ignoreErrors section in the main config. But it would be great if PHPStan was smarter here and used [0-9]+ for T_* in regexes 🙂.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different PHP versions have different value for T_STRING, it can't be hardcoded in the ignored error message.