chore: few SCA fixes and dev-tools update #7969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public static function tearDownAfterClass(): void | ||
| { | ||
| parent::tearDownAfterClass(); |
There was a problem hiding this comment.
Parent method is empty, this is superfluous. Same for setUpBeforeClass.
There was a problem hiding this comment.
I will have no clue to call the parent method in child class if i only modify parent method. or if parent method is modified of PHPUnit level.
with that, whenever we override PHPUnit's method, i want to build on top, not to replace PHPUnit method
Wirone
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.