feat: @PhpCsFixer ruleset - normalize implicit backslahes in single quoted strings
#7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mvorisek
force-pushed
the
phpcsfixer_fix_implicit_backslashes_consistently_internal_only
branch
from
aebabe8
to
8fe7f1d
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mvorisek
changed the title
@PhpCsFixer ruleset - normalize implicit backslahes in single quoted strings
mvorisek
force-pushed
the
phpcsfixer_fix_implicit_backslashes_consistently_internal_only
branch
from
8fe7f1d
to
cd21ad8
Compare
mvorisek
force-pushed
the
phpcsfixer_fix_implicit_backslashes_consistently_internal_only
branch
from
cd21ad8
to
02d96a9
Compare
|
Can this PR be approved? It is unambiguous that backslashes are commonly & significantly not quoted * and thus this the new config is the only one preferred. * here before #7786, Symfony, Lavarel, ... |
if you say this is Symfony best practice, add it to Sf ruleset and not Fixer's own one. |
keradus
reviewed
May 4, 2024
| @@ -119,7 +119,7 @@ public function getRules(): array | |||
| 'single_line_comment_style' => true, | |||
| 'single_line_empty_body' => true, | |||
| 'single_line_throw' => false, | |||
| 'string_implicit_backslashes' => ['single_quoted' => 'ignore'], | |||
| 'string_implicit_backslashes' => true, | |||
There was a problem hiding this comment.
for changing any ruleset, remember to update ruleset integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested in #7786 (review)