fix: Remove unnecessary method-proxying calls #7959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar as #7957 this PR is trying to remove unnecessary layers of indirection, which create a huge amount of function calls (millions).
see blackfire profile before this PR:
see profile comparison before/after PR:
you can see here that a few fixers need to call
getPrevMeaningfulToken->getMeaningfulTokenSibling->getTOkenNotOfSibling->getTokenNotOfKind.each of these method calls in between are just stacking up a new function call without any other additional logic.