fix: PhpdocArrayTypeFixer - JIT stack limit exhausted
#7895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Mar 18, 2024
Wirone
approved these changes
Mar 22, 2024
|
Thank you @kubawerlos and @mvorisek 馃嵒! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I had a fix, but #7843 changed that 馃槃.
Replacing
*+with*inTypeExpressionin lines 143, 144, 145, 146, 150 and 151 (not sure if all needed) was a "fix" few hours ago, but then (after merging #7843) to have test added here pass forPhpdocArrayTypeFixerTestI'd need to revert changes made there.I will try to fix it tomorrow, but @mvorisek you are the expert in this area, you probably know the line to fix after reading the test case 馃榿.