fix: StatementIndentationFixer - handle monolithic php only
#7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
changed the title
StatementIndentationFixer - handle monolithic php onlyStatementIndentationFixer - handle monolithic php only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing indentation in non-monolithic files is difficult. Multiple issues regarding this were closed as not planned (e.g. #7836 and #7754).
So I think the fixer should not try to fix non-monolithic files. It would avoid these issues.
I know there is also #6517. However, I would prefer to only disable rules that actually have issues with non-monolithic files.