feat: allow arbitrary space indentation #7818
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rasmus-Bertell
changed the title
keradus
reviewed
Feb 4, 2024
| @@ -25,8 +25,8 @@ final class WhitespacesFixerConfig | |||
|
|
|||
| public function __construct(string $indent = ' ', string $lineEnding = "\n") | |||
| { | |||
| if (!\in_array($indent, [' ', ' ', "\t"], true)) { | |||
| throw new \InvalidArgumentException('Invalid "indent" param, expected tab or two or four spaces.'); | |||
| if (!Preg::match('/^(?: +|\t)$/', $indent)) { | |||
There was a problem hiding this comment.
IF we would go forward direction to approve the PR, we need a new tests to prove it works:
- each fixer that uses WhitespacesFixerConfig should receive a new test with new whitespace variant(s)
- dedicated integration tests for new whitespace variant(s) (at least mimic
tests/Fixtures/Integration/set/@PSR12_whitespaces.test*.php)
(i suggest to not invest into it till aligned into direction)
There was a problem hiding this comment.
I'll convert this to a draft while I familiarize myself more with the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to address the issue in #7810.
Removes the limitation of having only 2 or 4 space indentation and allows for any number of spaces or one tab in the indentation settings.
This could be modified to also allow for any number of tabs but I don't see a reason for it since tabs are already arbitrary sized.