fix: Do not shorten FQN for class resolution if imported symbol is not a class #7705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in #7704 there is a fix already :) |
Previously all imports in the processed namespace were flattened to one list and use later for shortening. We need to have imports list sliced by import kind, so we can use proper imports in the context of currently processed part of code (e.g. use only class imports when processing function arguments).
|
@mvorisek Are you telling me I wasted my time for implementing this 😩? Eeehhhh.... |
mvorisek
reviewed
Jan 10, 2024
| if ($this->cacheUsesLast === $uses) { | ||
| return; | ||
| } | ||
| foreach ($uses as $kind => $kindUses) { |
There was a problem hiding this comment.
the foreach must be put right before the other foreach
This was referenced Jan 15, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7652