feat: Ability to skip "meta" tokens (whitespace, comments, attributes) #7559
Conversation
| @@ -572,6 +584,43 @@ public function getNonWhitespaceSibling(int $index, int $direction, ?string $whi | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
In general, for any code:
I struggle to understand the need for code without that code being used. For now, it looks only as a dead code
( and I would love to have automation to prevent any deadcode being in repo, as side note ;) )
I also fail to understand how common this will get used - is it's needed only for very limited usecase (and thus encapsulated into method of class, where will be the usage) or spread across widely (thus should be exposed via "main" Tokens).
For that, I would love to see actual usage of code, eg in the PR that is actually using it.
We could also have a PR adding Tokens code (without usage), and other feature PR build on top, that shows how it will be used.
Or other way around, merge feature PR without having this logic externalised to Tokens, and then refactoring PR with code moving to Tokens and getting use in multiple rules.
| @@ -572,6 +584,43 @@ public function getNonWhitespaceSibling(int $index, int $direction, ?string $whi | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Get index for closest sibling token which is non meta (whitespace, comment, PHP8 attribute). | |||
There was a problem hiding this comment.
curious - is meta some formal naming here, or only a word you picked? (happy with both, just curious)
| /** | ||
| * Get index for closest sibling token which is non meta (whitespace, comment, PHP8 attribute). | ||
| * | ||
| * @param int $index token index |
There was a problem hiding this comment.
| * @param int $index token index |
|
Since this pull request has not had any activity within the last 90 days, I have marked it as stale. The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way. You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point. I will close it if no further activity occurs within the next 14 days. Please keep your branch up-to-date by rebasing it when main branch is ahead of it, thanks in advance! |
github-actions
bot
added
status/to verify
I got this idea while reviewing #7395, I believe it could be helpful to achieve this (jump directly from
#[to meaningful element described with that attribute, then run attribute analysis).