feat: Introduce NoEmptyBlockFixer

[Wirone]

Fixes #3514, created by @ntzm, rebased and synced with current requirements by me 😉.

1 test case is failing, I will investigate only after initial green light that we actually want this fixer (@keradus said it's OK if it's marked as risky, and it is).

[ntzm]

Wow, I never thought anyone would use my branch for anything, nice one :D

[keradus]

while($itrator->consume()) {}

I wonder if it makes sense to have config which structures could be removed

[Wirone]

It can be added later as improvement, I would rather leave it as is now.

[keradus]

<?php

echo 1;

{}

echo 2;

[Wirone]

Fixer must be a candidate for input code. - currently fixer works for loops, switches etc. Is it required to handle this case?

[keradus]

I would imagine {} to be handled by NoEmptyBlockFixer, if we want to touch only loop, then we would have NoEmptyBodyBlockOfLoopFixer, but I would recommend to not have that very specialized rule that covers only some limited cases

[Wirone]

I agree, I just don't think that rule must cover every possible scenario since the very beginning. It's not my code, I just refurbished it from the ancient branch, I would like to provide it "as-is" (not counting required alignments). Then we can improve it even more. Example with {} is such an edge case that in my opinion doesn't have to be handled now.

[Wirone]

@ntzm do you have an idea why nested if test case fails? I did not have time to dig it yet, maybe you can help make pipeline green?

[ntzm]

Not sure sorry, I don't really have any capacity nowadays to work on anything PHP open source related 😢

[SpacePossum]

As it fixes if and else blocks, should this fix elseif blocks as well?
seems elseif is already covered

As it fixes finally, should this fix catch blocks as well?
seems catch is already covered, but is missing bunch of test cases;

• multiple catch types (catch(Foo|Bar $e){})
• without assigning (catch(A){})

The name is "empty block" as enduser I would expect this to be fixed as well:
(raised by others, but this is the most obvious empty block usage so, IMHO, should be fixed by this rule)

<?php {}
echo 1;
{}
?>

[Wirone]

@SpacePossum please look here 😉. I've rebased it only without any additional changes, will try to solve CI issues soon but I don't want to work on this PR more than it's required. Any improvements can be added later.

[Wirone]

@SpacePossum which question of yours I did not respond to 🤷‍♂️? In terms of empty {} I just redirected you to other thread where I already said I don't want to support it. It's not my code, I just refreshed @ntzm's work and I try to make it pass CI in my spare time. Then I will make final code review myself, as I feel more like reviewer here. I don't get what do you want from me, really 🙂.

I said I just did a rebase without any code changes to keep PR up-to-date so it's not marked as stale. When I will actually work on it, I'll take your comment into consideration. What's the problem here?

[SpacePossum]

Not sure about a "problem," but this PR doesn't look finished to me, no matter who was or is the author, so I can ask no?
I tried something here
Wirone#3
take or leave, really strange talk, feel free to tag me "off topic" again :)