feature: add "force" option to PhpUnitDataProviderStaticFixer #6757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4520417842
💛 - Coveralls |
keradus
reviewed
Mar 24, 2023
keradus
reviewed
Mar 24, 2023
| Rule sets | ||
| --------- | ||
|
|
||
| The rule is part of the following rule set: | ||
|
|
||
| @PHPUnit100Migration:risky | ||
| Using the `@PHPUnit100Migration:risky <./../../ruleSets/PHPUnit100MigrationRisky.rst>`_ rule set will enable the ``php_unit_data_provider_static`` rule. | ||
| Using the `@PHPUnit100Migration:risky <./../../ruleSets/PHPUnit100MigrationRisky.rst>`_ rule set will enable the ``php_unit_data_provider_static`` rule with the default config. |
There was a problem hiding this comment.
I wonder if we can have the new option used in some ruleset. I have a feeling that if we do not, the ppl will not be aware about this option and not using it.
[no good answer to this, myself]
There was a problem hiding this comment.
Let's for a start do it in @PhpCsFixer:risky, but in separate PR as there are quite few changes (including sorting of function that makes diff big).
There was a problem hiding this comment.
Adding force option to @PHPUnit100Migration:risky might have more sense as without it the migration might not be successful (with it also as it will break the test suite, but will make it closer to successful migration).
keradus
reviewed
Mar 24, 2023
keradus
reviewed
Mar 24, 2023
Wirone
requested changes
Mar 25, 2023
keradus
approved these changes
Mar 25, 2023
|
Thank you @kubawerlos 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6696 to help fully migrate to static data providers.