-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uncaught TypeError #6719
Fix uncaught TypeError #6719
Conversation
Pull Request Test Coverage Report for Build 3738920756
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this!
@@ -283,7 +283,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
if ('none' === $progressType || null === $stdErr) { | |||
$progressOutput = new NullOutput(); | |||
} else { | |||
$finder = new \ArrayIterator(iterator_to_array($finder)); | |||
$finder = new \ArrayIterator($finder); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this line before this if
? This would remove the need to do the same at line 316.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it might be better to replace count()
with iterator_count()
so we don't need to rely on ArrayIterator
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a test to prevent regression.
fixes #6718