Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Undefined array key "type" (doctrine/annotations 1.14.0) #6705

Closed

Conversation

Yurunsoft
Copy link
Contributor

No description provided.

@@ -58,7 +58,7 @@ public static function createFromDocComment(PhpToken $input, array $ignoredTags
$index = 0;
$nbScannedTokensToUse = 0;
$nbScopes = 0;
while (null !== $token = $lexer->peek()) {
while ($token = $lexer->peek()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be done. Because doctrine/annotations introduced a breaking change for that.
Question is if the check should be to call empty() or something.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check for both null and [] ? But perhaps the change introduced in doctrine/annotations was not intentional. Maybe wait to see how they respond.

@derrabus
Copy link
Contributor

Is this change obsolete after doctrine/annotations#463?

@icanhazstring
Copy link

Should be closed. Was fixed upstream 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants