feature: add PhpUnitDataProviderStaticFixer #6702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3833873772
💛 - Coveralls |
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
| $tokensAnalyzer = new TokensAnalyzer($tokens); | ||
|
|
||
| $inserts = []; | ||
| foreach ($dataProviderAnalyzer->getDataProviders($tokens, $startIndex, $endIndex) as $dataProviderAnalysis) { |
There was a problem hiding this comment.
I wonder about functional programming here... yeah - totally out of scope of this PR. but hey... DS\Vector?
looks like:
$allAnalysis
->filter(check for $this usage)
->map(convert to `function` index)
->filter(check if already static)
There was a problem hiding this comment.
Sounds like fun, for refactoring, especially the part with figuring out how to handle keys in this case.
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 27, 2022
keradus
reviewed
Dec 28, 2022
keradus
reviewed
Dec 28, 2022
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
keradus
reviewed
Jan 3, 2023
keradus
reviewed
Jan 3, 2023
keradus
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-static data providers will be deprecated in PHPUnit 10 and removed in PHPUnit 11.
(fixer that actually made: #6696)