phpdoc_types_order alters an intersection type into an union
#6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok I've replaced the regression test with a lower-level one, and I've found the culprit: 8b8eca0 Issue is that the fix is definitely out of my league... More details in #6238 (comment) @SpacePossum @keradus any help? Looking at the number of linked issues in the main one this is lighting up a lot of CIs... |
|
Closing in favor of #6243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP -- this is just porting the issue into a regression integration test. I'll try to dig it a bit but I'm not sure I'm able to fix it all by myself...