Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow global import in class without namespace #6192

Closed
wants to merge 1 commit into from
Closed

Allow global import in class without namespace #6192

wants to merge 1 commit into from

Conversation

chr-hertel
Copy link

Aims to fix #4726

@chr-hertel
Copy link
Author

This is not sufficient and tests are failing. Will have another look in sunday.

@SpacePossum
Copy link
Contributor

Thanks for making the PR and putting time and effort into looking into this issue.
The solution direction picked here seems a bit late in the stack I feel, I think the underlying issue is within the logic that should correctly figure out which imports are done within the scope of the namespace that is relevant. I'm trying to fix this in another PR (#6197) which still needs a bunch of work, but wanted to let you know that we might be looking and working on the same thing here :)

@SpacePossum
Copy link
Contributor

fixed in #6197 (I hope)

@chr-hertel chr-hertel deleted the 4726-global-import branch January 23, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fully_qualified_strict_types messes up when same classname is imported from global and non-global namespace
2 participants