Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use expectNotToPerformAssertions instead of addToAssertionCount #6186

Closed
wants to merge 2 commits into from
Closed

Use expectNotToPerformAssertions instead of addToAssertionCount #6186

wants to merge 2 commits into from

Conversation

kubawerlos
Copy link
Contributor

Doing $this->addToAssertionCount(1); is like doing assertTrue(true) - it tests nothing, BUT generates fake coverage.

Doing $this->expectNotToPerformAssertions(); the coverage is not generated.

@coveralls
Copy link

coveralls commented Dec 15, 2021 •
edited

Coverage Status

Coverage remained the same at 93.034% when pulling 9daa68c on werlos:use_expectNotToPerformAssertions into 80e7ca1 on FriendsOfPHP:master.

SpacePossum
SpacePossum reviewed Dec 16, 2021
View reviewed changes
tests/PregTest.php Outdated Show resolved Hide resolved
@kubawerlos kubawerlos closed this Jan 9, 2022
@kubawerlos kubawerlos deleted the use_expectNotToPerformAssertions branch January 9, 2022 21:37
@SpacePossum SpacePossum mentioned this pull request Jan 12, 2022
Merged
SpacePossum added a commit that referenced this pull request Jan 12, 2022
@SpacePossum
minor #6232 Use expectNotToPerformAssertions where applicable (SpaceP…
ee92352 
…ossum)

This PR was merged into the master branch.

Discussion
----------

Use expectNotToPerformAssertions where applicable

replaces #6186 as it was closed and branch deleted before merging

Commits
-------

2b03444 Use expectNotToPerformAssertions where applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum SpacePossum left review comments

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @coveralls @SpacePossum