Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update used PHP version #6163

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Expand Up @@ -25,18 +25,13 @@ jobs:
job-description: 'with Sf ^5'
execute-flex-with-symfony-version: '^5' # Explicit check for Sf 5.x compatibility

- operating-system: 'ubuntu-20.04'
php-version: '8.0'
job-description: 'with Sf ^6'
execute-flex-with-symfony-version: '^6' # Explicit check for Sf 6.x compatibility

- operating-system: 'ubuntu-20.04'
php-version: '7.4'
job-description: 'with deployment'
execute-deployment: 'yes'

- operating-system: 'ubuntu-20.04'
php-version: '8.0'
job-description: 'with Sf ^6'
execute-flex-with-symfony-version: '^6' # Explicit check for Sf 6.x compatibility

- operating-system: 'ubuntu-20.04'
php-version: '8.1'
Expand All @@ -49,13 +44,18 @@ jobs:
calculate-code-coverage: 'yes'
phpunit-flags: '--testsuite coverage --exclude-group covers-nothing --coverage-clover build/logs/clover.xml'

- operating-system: 'ubuntu-20.04'
php-version: '8.1'
job-description: 'with deployment'
execute-deployment: 'yes'

- operating-system: 'windows-latest'
php-version: '7.4'
php-version: '8.1'
job-description: 'on Windows'
FAST_LINT_TEST_CASES: 1

- operating-system: 'macos-latest'
php-version: '7.4'
php-version: '8.1'
job-description: 'on macOS'

name: PHP ${{ matrix.php-version }} ${{ matrix.job-description }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sca.yml
Expand Up @@ -12,7 +12,7 @@ jobs:
operating-system:
- ubuntu-20.04
php-version:
- 8.0
- 8.1

name: Static Code Analysis

Expand Down
2 changes: 1 addition & 1 deletion tests/AutoReview/CiConfigurationTest.php
Expand Up @@ -63,7 +63,7 @@ public function testDeploymentJobsRunOnLatestStablePhpThatIsSupportedByTool(): v
{
$ciVersionsForDeployments = $this->getAllPhpVersionsUsedByCiForDeployments();
$ciVersions = $this->getAllPhpVersionsUsedByCiForTests();
$expectedPhp = '7.4'; // can't run dev-tools on 8.0 yet; $this->getMaxPhpVersionFromEntryFile();
$expectedPhp = $this->getMaxPhpVersionFromEntryFile();

if (\in_array($expectedPhp.'snapshot', $ciVersions, true)) {
// last version of used PHP is snapshot. we should test against previous one, that is stable
Expand Down