Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: update composer-normalize #6147

Merged
merged 1 commit into from
Dec 6, 2021
Merged

DX: update composer-normalize #6147

merged 1 commit into from
Dec 6, 2021

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 6, 2021

No description provided.

@keradus keradus added the RTM Ready To Merge label Dec 6, 2021
@SpacePossum SpacePossum added topic/tests and removed RTM Ready To Merge labels Dec 6, 2021
@SpacePossum
Copy link
Contributor

Thank you @keradus.

@SpacePossum SpacePossum merged commit 6431ccc into PHP-CS-Fixer:master Dec 6, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.847% when pulling 7bba5c7 on keradus:composer_normalise into 075082e on FriendsOfPHP:master.

@keradus keradus deleted the composer_normalise branch December 6, 2021 20:37
@keradus
Copy link
Member Author

keradus commented Dec 6, 2021

extra note: looks like PRs started failing on new normaliser version. Was this change expected, @localheinz ?

@localheinz
Copy link
Member

localheinz commented Dec 6, 2021 •
edited

@keradus

Apologies for the delay, I have been quite busy these last months.

Thanks to some reordering of the original Schema as provided by composer/composer, these changes are expected.

See ergebnis/composer-normalize#779.

@keradus
Copy link
Member Author

keradus commented Dec 8, 2021

delay? what delay? you are way faster than me ;)

thanks for context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
topic/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keradus @SpacePossum @coveralls @localheinz