New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhpdocTypesOrderFixer - Improve nested types support #6063
PhpdocTypesOrderFixer - Improve nested types support #6063
Conversation
a19f9ad
to
6ceb7e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding regular expression. Or scary. Or both 🙇🏼♂️
@@ -31,39 +32,47 @@ final class TypeExpression | |||
public const REGEX_TYPES = ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe it's time (outside of this PR) to start looking for external library managing types parsing
I tested this branch on a project and I can't wait for this to be merged. What's left to do ? I might dedicate some time to get this in asap! Thanks |
Maybe more review would be nice to be more confident this won't break things, any help is welcome :) @keradus did you review this fully? |
unfortunately not at all, was focusing on PHP8.1/Symfony6 reviews. maybe someone else can review this PR? |
@kubawerlos already did. Given that several people reported the changes in this PR fixed the issue for them, I consider this can be merged. |
Please do merge it! :-) Our team is waiting for this change as well. |
@julienfalque please resolve the conflict, squash and than tag this PR RTM when the tests are green, thanks 👍 : ) |
6ceb7e4
to
0c76fe5
Compare
Thank you @ruudk and @julienfalque :) |
Fixes #5850, #5921 and replaces #5919. It also improves nested union types support.