NullableTypeTransformer - fix for attributes #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Apr 5, 2021
|
It looks like this does not fix my case. It works well without a default value, but that's the case before this fix too 🤔 Can you extend your test case like proposed in my comment? |
OskarStark
reviewed
Apr 6, 2021
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
@OskarStark added, since in #5533 you haven't added a config I can only guess, let's go with this one and verify if you still have the issue. Might be another bug lurking at us. |
|
Yes |
keradus
approved these changes
Apr 6, 2021
|
Thank you @kubawerlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5533