Fix CS config by default too

[mvorisek]

fabbot.io Use ::class whenever possible should be ignored, otherwise PHPStan is not happy, unrelated with this PR...

[coveralls]

Coverage increased (+0.004%) to 91.855% when pulling cc3312c on mvorisek:patch-2 into 9bf2760 on FriendsOfPHP:2.18.

[mvorisek]

@keradus can this be merged and which branch to target?

[kubawerlos]

@mvorisek what about this comment: #5467 (comment) ?

[mvorisek]

Both comments are now addressed, is everyone happy now? :)

[kubawerlos]

fabbot isn't 😉

[mvorisek]

fabbot isn't 😉

@kubawerlos I tried to please this bot too with 342d09c, but if I follow the bot advise, I get:

 ------ --------------------------------------------- 
  Line   tests/Console/ConfigurationResolverTest.php  
 ------ --------------------------------------------- 
  208    Class Test1Config not found.                 
  218    Class Test4Config not found.                 
 ------ --------------------------------------------- 

from phpstan. Let me know what to do with this, the fabbot error is unrelated, only some unrelated change was done in that file.

[keradus]

I'm not convinced for this change, myself. I'm thinking about alternatives

[mvorisek]

I'm not convinced for this change, myself. I'm thinking about alternatives

Please tell your concerns.

[keradus]

I wasn't concerned. I was not convinced.
For some weeks we were discussing about another naming pattern for config file within core team.
I decided to reject this PR as it's obsolete with new naming pattern: #5607

Thanks for all the effort.

[mvorisek]

Yes, a lot of work, but new .php suffix makes sense, 👍