-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LineEndingFixer - BracesFixer - Priority #4245
LineEndingFixer - BracesFixer - Priority #4245
Conversation
Thanks for all the profiling on priorities! --edit: bunch of typos and wording |
I just checked, braces never inserts hardcoded newlines, they come from the whitespace config. It does do some string-magic with |
… priority issue (dmvdbrugge) This PR was merged into the 2.12 branch. Discussion ---------- MethodChainingIndentationFixer, ArrayIndentationFixer - Fix priority issue Fixes #4271. Pre-2.12.5 `MethodChainingIndentationFixer` had no priority, I introduced it in #4084. It now needs to be upped because it needs to keep running before `ArrayIndentationFixer`. Lowering `ArrayIndentationFixer` was not an option as it already has multiple fixers running after it (which are in the `FixerFactoryTest`, but not in its comments, however the comments are already being fixed in #4245). Commits ------- a6bd13c MethodChainingIndentationFixer should run before ArrayIndentationFixer
a57802c
to
33f5fcd
Compare
note to self, 7.3 failures are not related to this PR |
Thank you @dmvdbrugge. |
Separated the
line_ending
/braces
-priority relation and some comments from #4085