BracesFixer - NoTrailingWhitespaceInCommentFixer - Priority #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvdbrugge
force-pushed
the
3880-braces-before-no_trailing_whitespace_in_comment
branch
from
e385a2f
to
1ea33b0
Compare
dmvdbrugge
force-pushed
the
3880-braces-before-no_trailing_whitespace_in_comment
branch
from
1ea33b0
to
5ecb25c
Compare
dmvdbrugge
changed the title
SpacePossum
added a commit
that referenced
this pull request
Mar 29, 2019
…ment (SpacePossum) This PR was merged into the 2.12 branch. Discussion ---------- BracesFixer - Do not pull close tag onto same line as a comment replaces #4094 this stops the fixer changing: ```php <?php if ($a) { // ?> ``` into ```php <?php if ($a) { // ?> ``` Commits ------- 843ae37 Do not pull close tag onto same line as a comment
|
replaced with #4346 |
dmvdbrugge
deleted the
3880-braces-before-no_trailing_whitespace_in_comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3880
when #4085 is merged first 😜(Test will thus fail for now, and succeed after rebase when said PR is merged.)Separated from #4085 by just specifying a lower priority.