inline $other->getPrototype() to speedup equals() #4040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 14, 2018
| @@ -156,34 +156,44 @@ public function clearChanged() | |||
| */ | |||
| public function equals($other, $caseSensitive = true) | |||
| { | |||
| $otherPrototype = $other instanceof self ? $other->getPrototype() : $other; | |||
| if ($other instanceof self) { | |||
There was a problem hiding this comment.
not sure I got all cases right. we need to double-check and maybe increase test-coverage in case this is not yet covered.
keradus
reviewed
Oct 14, 2018
src/Tokenizer/Token.php
Outdated
| } | ||
|
|
||
| if (array_key_exists(0, $otherPrototype) && $this->id !== $otherPrototype[0]) { | ||
| if (\array_key_exists(0, $other) && $this->id !== $other[0]) { |
There was a problem hiding this comment.
please revert backslashing.
we rely on native_function_invocation rule, that's it
There was a problem hiding this comment.
this path is very very hot, and paying this additional namespace lookup here makes a difference.
There was a problem hiding this comment.
after #4041 its no longer measurable.
|
resubmitted with new merge base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as measured in #4026 we try to speedup equals() by inlinening the $this->getPrototype() call.
also we use FQCN for native functions, because equals() is called a lot.
this speedsup the process by 4-5%.
see https://blackfire.io/profiles/compare/f4eefae8-6d09-4ab4-a833-f828d74a7b52/graph
