Add DeclaredClassCasingFilter

[siad007]

Related to #2571

[ntzm]

So the scope here has changed to use declared classes instead of native classes. I don't like this change because the output of the fixer can be changed depending on what classes are defined before construction, which in my case of using it as a library, it could be anything. Also, different environments will produce different results, such as:

• I am using ext-pdo on my local environment, which defines the PDO class
• I have some code that uses PDo
• On my local, when I run the fixer, it fixes it correctly to PDO
• However, on my CI setup, I might not have ext-pdo enabled, so it wouldn't fix that case

[SpacePossum]

I don't share that concern, if you use different PHP builds/SAPI you get different results from a range of fixers already. It is also a one way fix, so on one system it fixes more than on another, but it never reverts a good fix.

[ntzm]

@siad007 would you like someone to finish off this PR if you haven't got time to? It's a very useful fixer

[kubawerlos]

I'm sceptical about this line - get_declared_classes will not return classes that are declared, but those declared in the current script - depending how autoloader was called - which mean one day it will return some classes and another day more classes - adding some fixer to config might accidentally "discover" more classes.

When I was working on similar fixer I have ended with only internal classes to handle.

[siad007]

@ntzm i have fixed the last pending issues right now

[SpacePossum]

@siad007 thanks for the update.
I added another commit, please re-review @ntzm and @kubawerlos . Note that this fixer does not fix classes outside of the global namespace, so even if more classes are already loaded it, for example it will never fix Foo\bar, only \Foo and Foo (if needed)

[ntzm]

Should this not be fixed to

use stdClass as exception;

?

[SpacePossum]

@siad007 can you pick this up? also rebase and squash this, then change the target branch to master please :)

[SpacePossum]

Thanks @siad007 for all the work here!

The feature has been added to the code base here #6262 , with big difference that it only fixes internal class names and addresses some other feedback items from here, thanks all 👍