ArgumentsAnalyzer - pass by reference not analyzed correctly #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Aug 9, 2018
|
|
||
| try { | ||
| $fixer->fix(new \SplFileInfo(__FILE__), $tokens); | ||
| } catch (RequiredFixerConfigurationException $e) { |
There was a problem hiding this comment.
if this happen, we do not know that fixer works for empty file
by silencing the error, we lied to our-self that it does
keradus
reviewed
Aug 9, 2018
| @@ -126,6 +126,16 @@ public function provideArgumentsInfoCases() | |||
| 3 | |||
| ) | |||
| )], | |||
| ['<?php function(array & $a){};', 3, 7, new ArgumentAnalysis( | |||
|
You could've save the trouble, as this was already in pr: #3924 ... |
|
@SpacePossum , can you please leave |
|
@SpacePossum , I merged 3924, please rebase to leave only tests for empty content |
|
nothing much of value here, closing as such |
|
what about those tests for empty (or almost-empty) files ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name ended up being
array&