New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install/update instructions for PHIVE to the README #3848
Add install/update instructions for PHIVE to the README #3848
Conversation
README.rst
Outdated
|
||
.. code-block:: bash | ||
|
||
$ phive install php-cs-fixer # use `--global` for global install, not recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop , not recommended
. It's opinionated, and even while I agree with it, we don't put that for other ways of installation, don't we ?
Here, i brings the confusion that installing sth with PHIVE globally is not recommended, it's not true.
We simply don't recommend to install dev-tools globally (as their versions depends on project), regardless which way of installation was chosen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so maybe just drop the comment completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would keep it
@@ -131,6 +131,15 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
|
|||
$ brew install php-cs-fixer | |||
|
|||
Locally (PHIVE) | |||
~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so long? Other underline-ish lines are with the length of the text above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll admit, the lengthy ~
is a result of copying another (sub)header, I'll update soon, thanks for the sharp review 👍 :)
@@ -124,6 +133,13 @@ You can update ``php-cs-fixer`` through this command: | |||
|
|||
$ brew upgrade php-cs-fixer | |||
|
|||
Locally (PHIVE) | |||
~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No so fast, this one is also too long ;)
Oh, already merged :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, I really really really thought I had this covered, f**k me, this is a lesson learned on my "I wished wasn't needed "-list :(
aaarrggh I'm sorry man, you called me out on it before and still I messed it up, f**k me :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worry. instead of fixing that, let us run rst / md linters on CI :D
closes #3838