Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix type error when using paths intersection mode #6734

Merged

Conversation

julienfalque
Copy link
Member

Fixes #6718 and replaces #6719.

@coveralls
Copy link

coveralls commented Jan 2, 2023

Pull Request Test Coverage Report for Build 3825623956

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 151 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.5%) to 92.926%

Files with Coverage Reduction New Missed Lines %
src/Fixer/ClassNotation/OrderedInterfacesFixer.php 1 98.91%
src/Fixer/Casing/NativeFunctionCasingFixer.php 6 72.73%
src/Fixer/Strict/StrictParamFixer.php 8 87.69%
src/Fixer/Casing/MagicConstantCasingFixer.php 12 57.14%
src/Fixer/Casing/ConstantCaseFixer.php 20 68.18%
src/Fixer/Casing/ClassReferenceNameCasingFixer.php 23 68.06%
src/Fixer/ControlStructure/NoUnneededControlParenthesesFixer.php 34 86.25%
src/Fixer/Operator/NewWithBracesFixer.php 47 54.81%
Totals Coverage Status
Change from base Build 3805480085: -0.5%
Covered Lines: 22556
Relevant Lines: 24273

💛 - Coveralls

@keradus keradus closed this Jan 2, 2023
@keradus keradus reopened this Jan 2, 2023
@@ -93,7 +106,7 @@ private function getDefaultArguments(): array
return [
'path' => [__FILE__],
'--path-mode' => 'override',
'--allow-risky' => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -29,6 +30,19 @@
*/
final class FixCommandTest extends TestCase
{
public function testIntersectionPathMode(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome to have the test for this!

@keradus keradus mentioned this pull request Jan 2, 2023
@keradus
Copy link
Member

keradus commented Jan 2, 2023

kudos @julienfalque !

@keradus keradus merged commit 09e5570 into PHP-CS-Fixer:master Jan 2, 2023
@julienfalque julienfalque deleted the fix-intersection-path-error branch January 3, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error on PHP 8.1.13 using path-mode intersection
3 participants