DX: cleanup PhpUnitStrictFixerTest (#7938)

PHP-CS-Fixer · Apr 11, 2024 · f3aa277 · f3aa277
1 parent 75168ee
commit f3aa277
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 18 deletions.
diff --git a/phpstan.dist.neon b/phpstan.dist.neon
@@ -21,6 +21,6 @@ parameters:
         -
             message: '#^Method PhpCsFixer\\Tests\\.+::provide.+Cases\(\) return type has no value type specified in iterable type iterable\.$#'
             path: tests
-            count: 1020
+            count: 1019
     tipsOfTheDay: false
     tmpDir: dev-tools/phpstan/cache
diff --git a/tests/Fixer/PhpUnit/PhpUnitStrictFixerTest.php b/tests/Fixer/PhpUnit/PhpUnitStrictFixerTest.php
@@ -104,21 +104,8 @@ public static function provideFixCases(): iterable
                 self::generateTest("self::{$methodBefore}(1, \$a, '', );"),
             ];
         }
-    }
-
-    /**
-     * Only method calls with 2 or 3 arguments should be fixed.
-     *
-     * @dataProvider provideNoFixWithWrongNumberOfArgumentsCases
-     */
-    public function testNoFixWithWrongNumberOfArguments(string $expected): void
-    {
-        $this->fixer->configure(['assertions' => array_keys(self::getMethodsMap())]);
-        $this->doTest($expected);
-    }
 
-    public static function provideNoFixWithWrongNumberOfArgumentsCases(): iterable
-    {
+        // Only method calls with 2 or 3 arguments should be fixed.
         foreach (self::getMethodsMap() as $candidate => $fix) {
             yield sprintf('do not change call to "%s" without arguments.', $candidate) => [
                 self::generateTest(sprintf('$this->%s();', $candidate)),
@@ -138,7 +125,7 @@ public static function provideNoFixWithWrongNumberOfArgumentsCases(): iterable
         }
     }
 
-    public function testInvalidConfig(): void
+    public function testInvalidConfiguration(): void
     {
         $this->expectException(InvalidFixerConfigurationException::class);
         $this->expectExceptionMessageMatches('/^\[php_unit_strict\] Invalid configuration: The option "assertions" .*\.$/');

diff --git a/tests/Test/AbstractFixerTestCase.php b/tests/Test/AbstractFixerTestCase.php
@@ -82,7 +82,6 @@
 use PhpCsFixer\Tests\Fixer\PhpUnit\PhpUnitConstructFixerTest;
 use PhpCsFixer\Tests\Fixer\PhpUnit\PhpUnitDedicateAssertFixerTest;
 use PhpCsFixer\Tests\Fixer\PhpUnit\PhpUnitMethodCasingFixerTest;
-use PhpCsFixer\Tests\Fixer\PhpUnit\PhpUnitStrictFixerTest;
 use PhpCsFixer\Tests\Fixer\PhpUnit\PhpUnitTestCaseStaticMethodCallsFixerTest;
 use PhpCsFixer\Tests\Fixer\ReturnNotation\ReturnAssignmentFixerTest;
 use PhpCsFixer\Tests\Fixer\Semicolon\MultilineWhitespaceBeforeSemicolonsFixerTest;
@@ -503,7 +502,6 @@ final public function testProperMethodNaming(): void
             PhpUnitConstructFixerTest::class,
             PhpUnitDedicateAssertFixerTest::class,
             PhpUnitMethodCasingFixerTest::class,
-            PhpUnitStrictFixerTest::class,
             PhpUnitTestCaseStaticMethodCallsFixerTest::class,
             ReturnAssignmentFixerTest::class,
             ReturnTypeDeclarationFixerTest::class,