bug #3912 FullyQualifiedStrictTypesFixer - NoSuperfluousPhpdocTagsFix…

…er - adjust priority (dmvdbrugge)

This PR was merged into the 2.12 branch.

Discussion
----------

FullyQualifiedStrictTypesFixer - NoSuperfluousPhpdocTagsFixer - adjust priority

This fixes #3850

Commits
-------

fa17194 FullyQualifiedStrictTypesFixer - NoSuperfluousPhpdocTagsFixer - Priority

src/Fixer/Import/FullyQualifiedStrictTypesFixer.php

@@ -70,6 +70,16 @@ public function doSomething(\Foo\Bar $foo): \Foo\Bar\Baz
         );
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function getPriority()
+    {
+        // should run after PhpdocToReturnTypeFixer
+        // should run before NoSuperfluousPhpdocTagsFixer
+        return 7;
+    }
+
     /**
      * {@inheritdoc}
      */

tests/AutoReview/FixerFactoryTest.php

@@ -83,6 +83,7 @@ public function provideFixersPriorityCases()
             [$fixers['elseif'], $fixers['braces']],
             [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
             [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
+            [$fixers['fully_qualified_strict_types'], $fixers['no_superfluous_phpdoc_tags']],
             [$fixers['function_to_constant'], $fixers['native_function_casing']],
             [$fixers['function_to_constant'], $fixers['no_extra_blank_lines']],
             [$fixers['function_to_constant'], $fixers['no_singleline_whitespace_before_semicolons']],

tests/Fixtures/Integration/priority/fully_qualified_strict_types,no_superfluous_phpdoc_tags.test

@@ -0,0 +1,20 @@
+--TEST--
+Integration of fixers: fully_qualified_strict_types,no_superfluous_phpdoc_tags.
+--RULESET--
+{"fully_qualified_strict_types": true, "no_superfluous_phpdoc_tags": true}
+--EXPECT--
+<?php
+// No namespace
+/**
+ * @param bool $expected
+ */
+function testSomething(Foo $foo, $expected) {}
+
+--INPUT--
+<?php
+// No namespace
+/**
+ * @param Foo  $foo
+ * @param bool $expected
+ */
+function testSomething(\Foo $foo, $expected) {}