Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increment prerelease method #23

Closed
wants to merge 3 commits into from
Closed

increment prerelease method #23

wants to merge 3 commits into from

Conversation

oscar-ol
Copy link
Contributor

@oscar-ol oscar-ol commented Oct 29, 2022 •
edited

This PR adds a method to increment the version of the prerelease

$version->incrementPreRelease(); // v1.2.3-alpha.5 -> v1.2.3-alpha.6

@oscar-ol
add method to incrementable trait
dc06494 
change method __toString to allow prerelease "0"
tests
@oscar-ol
Update README.md
4214197
PHLAK
PHLAK reviewed Nov 2, 2022
View reviewed changes
tests/VersionTest.php Outdated Show resolved Hide resolved
tests/VersionTest.php Outdated Show resolved Hide resolved
@oscar-ol oscar-ol requested a review from PHLAK November 2, 2022 19:18
@PHLAK PHLAK mentioned this pull request Nov 3, 2022
Merged
@PHLAK
Copy link
Owner

PHLAK commented Nov 3, 2022 •
edited

Merged in #24

Thanks for the PR @oscar-ol!

@PHLAK PHLAK closed this Nov 3, 2022
@PHLAK PHLAK assigned PHLAK and oscar-ol and unassigned PHLAK Nov 3, 2022
@PHLAK PHLAK added the Enhancement New feature or request label Nov 3, 2022
@oscar-ol oscar-ol deleted the feature/add_increment_prerelease_method branch December 24, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHLAK PHLAK Awaiting requested review from PHLAK

Assignees

@oscar-ol oscar-ol

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscar-ol @PHLAK