Skip to content

Commit

Permalink
swctl: added usage condition for entity's extra file (#167)
Browse files Browse the repository at this point in the history
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
  • Loading branch information
fgschwan committed Jan 15, 2024
1 parent 4298f04 commit ae01f8c
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 18 deletions.
62 changes: 44 additions & 18 deletions cmd/swctl/app/cmd_manage.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,14 @@ func runManageCmd(cli Cli, opts ManageOptions, args []string) error {
}

for _, f := range entity.Files {
useFile, err := canUseExtraFile(f, evars)
if err != nil {
return fmt.Errorf("failed to evaluate When statement (%v) for file (%v): %w", f.When, f.Name, err)
}
if !useFile {
continue
}

rawData, err := renderEntityTemplate(f.Content, vars)
if err != nil {
return fmt.Errorf("failed to render file (%v): %w", f.Name, err)
Expand Down Expand Up @@ -629,25 +637,14 @@ func prepareVarValues(e Entity, evars map[string]string) (map[string]string, err

func prepareVarValuesInteractive(w io.Writer, e Entity, evars map[string]string) (map[string]string, error) {
for _, v := range e.Vars {
if v.When != "" {
tmpl, err := interpolateStr(v.When, evars)
if err != nil {
return nil, err
}
res, err := renderTmpl(tmpl, evars)
if err != nil {
return nil, err
}
ok, err := strconv.ParseBool(res)
if err != nil {
logrus.Tracef("parse bool err: %v", err)
continue
}
logrus.Tracef("when %s returned %q (%v)", v.Name, res, ok)
if !ok {
continue
}
useValue, err := canUseValue(v, evars)
if err != nil {
return nil, err
}
if !useValue {
continue
}

vv := v.Value
if ov, ok := evars[v.Name]; ok {
vv = ov
Expand Down Expand Up @@ -684,6 +681,35 @@ func prepareVarValuesInteractive(w io.Writer, e Entity, evars map[string]string)
return evars, nil
}

func canUseValue(value EntityVar, evars map[string]string) (bool, error) {
return isWhenTrue(value.When, evars, value.Name)
}

func canUseExtraFile(extraFile ExtraFile, evars map[string]string) (bool, error) {
return isWhenTrue(extraFile.When, evars, extraFile.Name)
}

func isWhenTrue(whenStatement string, evars map[string]string, name string) (bool, error) {
if whenStatement == "" {
return true, nil // by default, the value/file/... should be used
}
tmpl, err := interpolateStr(whenStatement, evars)
if err != nil {
return false, err
}
res, err := renderTmpl(tmpl, evars)
if err != nil {
return false, err
}
ok, err := strconv.ParseBool(res)
if err != nil {
logrus.Tracef("parse bool err: %v", err)
return false, nil
}
logrus.Tracef("when for %s returned %q (%v)", name, res, ok)
return ok, nil
}

func promptUserValue(label string, defval string) (string, error) {
prompt := promptui.Prompt{
Label: label,
Expand Down
1 change: 1 addition & 0 deletions cmd/swctl/app/entity.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ type Entity struct {
type ExtraFile struct {
Name string `json:"name"`
Content string `json:"content"`
When string `json:"when"`
}

func (e Entity) GetName() string {
Expand Down

0 comments on commit ae01f8c

Please sign in to comment.