Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the logger instanciation/initial handlers #135

Merged
merged 17 commits into from Nov 24, 2021
Merged

Revise the logger instanciation/initial handlers #135

merged 17 commits into from Nov 24, 2021

Commits on Nov 8, 2021

  1. Update logger to use NullHandler by default 

    Update api.py to preserve backwards compatability with recommended logging practices for python libraries
    @nmaynes
    nmaynes committed Nov 8, 2021
    Copy the full SHA
    465b3d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Add test class to cover Logging behavior

    @nmaynes
    nmaynes committed Nov 9, 2021
    Copy the full SHA
    0d86dda View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Update default behavior of explain parameter when false 

    Move logger into utils.py
Add test cases for stream handler behavior
    @nmaynes
    nmaynes committed Nov 18, 2021
    Copy the full SHA
    cf1251b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. Merge branch 'master' into enhancement/Ousret#134

    @Ousret
    Ousret committed Nov 20, 2021
    Copy the full SHA
    0dc5e65 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2021

  1. Merge branch 'master' into enhancement/Ousret#134

    @Ousret
    Ousret committed Nov 21, 2021
    Copy the full SHA
    372fe33 View commit details
    Browse the repository at this point in the history

  2. 🎨 Fix F401 '.utils.set_logging_handler' imported but unused

    @Ousret
    Ousret committed Nov 21, 2021
    Copy the full SHA
    3877243 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Merge branch 'master' into enhancement/Ousret#134

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    44e1922 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'nmaynes/enhancement/Ousret#134' into en… 

    …hancement/Ousret#134
    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    73fc337 View commit details
    Browse the repository at this point in the history

  3. ❇️ Having a dedicated final handler attached to the explain toggle

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    97136ef View commit details
    Browse the repository at this point in the history

  4. 🔧 Having the logger initialized in top level init 

    instead of utils.py
    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    5f29850 View commit details
    Browse the repository at this point in the history

  5. 📝 Add CHANGELOG entry

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    faa484c View commit details
    Browse the repository at this point in the history

  6. 🎨 reformat api.py

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    241eb2e View commit details
    Browse the repository at this point in the history

  7. 📝 Add CHANGELOG entry 

    about explain=True behavior
    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    53013dd View commit details
    Browse the repository at this point in the history

  8. 🔥 remove redundant chk if hld is present

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    7484dc7 View commit details
    Browse the repository at this point in the history

  9. ✔️ Add tests / enforce hdl checks

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    b326738 View commit details
    Browse the repository at this point in the history

  10. 🐛 Wrong rt logger got in api.py

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    e70f072 View commit details
    Browse the repository at this point in the history

  11. ✔️ Improve tests

    @Ousret
    Ousret committed Nov 24, 2021
    Copy the full SHA
    c3970d4 View commit details
    Browse the repository at this point in the history