Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logging library from ensembles module #1044

Merged
merged 6 commits into from Mar 29, 2022

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 28, 2022

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added
  • bumpversion patch has been called on this branch
  • The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

  • replaces logger and logging call with warnings

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Mar 28, 2022
@Zeitsperre Zeitsperre added this to the v0.35 milestone Mar 28, 2022
@Zeitsperre Zeitsperre self-assigned this Mar 28, 2022
@Zeitsperre
Copy link
Collaborator Author

Click just released a new version that is incompatible with the newest black (psf/black#2964). A version addressing this is being tagged today.

@coveralls
Copy link

coveralls commented Mar 28, 2022

Coverage Status

Coverage decreased (-0.002%) to 91.582% when pulling 694da2d on remove_ensembles_logging into 6eb9005 on master.

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With removing the other one and an update to the history, this is good to go!

The only other logging xclim does is in utils.py but this one is controllable via xclim options, so no need to touch it to close the issue.

HISTORY.rst Outdated Show resolved Hide resolved
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@Zeitsperre Zeitsperre removed this from the v0.35 milestone Mar 28, 2022
@Zeitsperre Zeitsperre merged commit 419f637 into master Mar 29, 2022
@Zeitsperre Zeitsperre deleted the remove_ensembles_logging branch March 29, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable logging in xclim.ensembles module?
3 participants