Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #165 (database version) #223

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Fix #165 (database version) #223

merged 2 commits into from
Oct 11, 2019

Conversation

davidcaron
Copy link
Contributor

@davidcaron davidcaron commented Oct 11, 2019

Fix for warning: "Textual SQL expression 'alembic_version' should be explicitly
declared as text('alembic_version')"

"Textual SQL expression 'alembic_version' should be explicitly
declared as text('alembic_version')"
@fmigneault
Copy link
Collaborator

@davidcaron
Does it only fix the warning or #165 is also fixed?
By this, I mean the version=null that is used by default in GET /magpie/version response because lookup of alembic_version fails.

@davidcaron
Copy link
Contributor Author

Yes, the /version route returns the proper alembic version number.

@fmigneault
Copy link
Collaborator

@davidcaron Nice.
Can you add a fix #165 note in the changelog?
After good to merge.

@fmigneault fmigneault self-requested a review October 11, 2019 14:59
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closes #165

@davidcaron davidcaron merged commit 82fe19c into master Oct 11, 2019
@fmigneault fmigneault deleted the fix/165 branch December 3, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants