Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 095 - OGN Buyback #2063

Merged
merged 7 commits into from
May 29, 2024
Merged

Deploy 095 - OGN Buyback #2063

merged 7 commits into from
May 29, 2024

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented May 16, 2024

Contracts

Note:

  • There's no proposal for this on mainnet.
  • Didn't add forceSkip or the entry in migrations.json since adding those would break tests now. Should be okay to add those once we have a proposal up on the ousd-governance repo

If you made a contract change, make sure to complete the checklist below before merging it in master.

Dependencies

Security

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.54%. Comparing base (2615d12) to head (c62b4fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2063   +/-   ##
=======================================
  Coverage   60.54%   60.54%           
=======================================
  Files          59       59           
  Lines        3021     3021           
  Branches      779      779           
=======================================
  Hits         1829     1829           
  Misses       1189     1189           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVF
Copy link
Member

DanielVF commented May 17, 2024

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • The transactions that interacted with the newly deployed contract match the deploy script.

(Governance proposal and smoke testing coming with the deploy on the other repo, these are just impl contract deploys)

DanielVF
DanielVF previously approved these changes May 17, 2024
@shahthepro shahthepro merged commit 0ffcc2b into master May 29, 2024
15 checks passed
@shahthepro shahthepro deleted the shah/deploy-095 branch May 29, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants