-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy 095 - OGN Buyback #2063
Merged
Merged
Deploy 095 - OGN Buyback #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahthepro
requested review from
sparrowDom,
DanielVF and
naddison36
as code owners
May 16, 2024 16:26
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2063 +/- ##
=======================================
Coverage 60.54% 60.54%
=======================================
Files 59 59
Lines 3021 3021
Branches 779 779
=======================================
Hits 1829 1829
Misses 1189 1189
Partials 3 3 ☔ View full report in Codecov by Sentry. |
(Governance proposal and smoke testing coming with the deploy on the other repo, these are just impl contract deploys) |
DanielVF
previously approved these changes
May 17, 2024
naddison36
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contracts
Note:
forceSkip
or the entry inmigrations.json
since adding those would break tests now. Should be okay to add those once we have a proposal up on the ousd-governance repoIf you made a contract change, make sure to complete the checklist below before merging it in master.
Dependencies
Security
Refer to our documentation for more details about contract security best practices.
Contract change checklist: