OETH withdrawal queue #2062
Draft
OETH withdrawal queue #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sparrowDom/nativeStaking #2062 +/- ##
============================================================
+ Coverage 62.99% 64.68% +1.68%
============================================================
Files 65 66 +1
Lines 3243 3358 +115
Branches 839 651 -188
============================================================
+ Hits 2043 2172 +129
+ Misses 1197 1183 -14
Partials 3 3 ☔ View full report in Codecov by Sentry. |
DanielVF
reviewed
May 17, 2024
DanielVF
reviewed
May 17, 2024
| // For future use | ||
| uint256[50] private __gap; | ||
| uint256[46] private __gap; |
There was a problem hiding this comment.
I see three slots added? dripper, withdrawalQueueMetadata, and withdrawalRequests. Shouldn't the gap change by 3, not four?
This particular gap is one that keeps me up at night. We should make sure our fork tests will catch an incorrect number here.
There was a problem hiding this comment.
There's three storage variables added but withdrawalQueueMetadata is a struct that takes up 2 slots hence the gap was reduced by 4 slots.
naddison36
force-pushed
the
nicka/oeth-arm
branch
from
e87bc07
to
e5ebf29
Compare
claimWithdrawal collects from Dripper and adds any unallocated WETH to the withdrawal queue if not enough liquidity available
depositToStrategy only deposits WETH not allocated to the withdrawal queue swapCollateral restricted to only swap to WETH swapCollateral adds to withdrawal queue after swap
…-scanner Moved duplicate getClusterInfo in tasks to utils
WIP withdrawal queue unit tests
Added more withdrawal queue coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract Changes
requestWithdrawal,claimWithdrawalandaddWithdrawalQueueLiquidity.Dependencies
Security
If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist: