Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OUSD Better Burn Mint #1680

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

OUSD Better Burn Mint #1680

wants to merge 1 commit into from

Conversation

DanielVF
Copy link
Member

@DanielVF DanielVF commented Jul 4, 2023

Changing over burning and minting to work from a balance centric point of view.

On burns this provides:

  • Can burn any amount
  • Can always burn account balance

While this passes current tests, and should be perfectly accurate for a hundred years worth of yield, it would be good to characterize worst case rounding results when resolution is insufficient.


Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@rafaelugolini rafaelugolini temporarily deployed to preview-oeth-danielvf-b-fdtw1j July 4, 2023 16:11 Inactive
@DanielVF DanielVF added the contracts Works related to contracts label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Works related to contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants