-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Vault functions and events with Ousd in them #1629
base: master
Are you sure you want to change the base?
Conversation
@@ -165,9 +165,9 @@ interface IVault { | |||
|
|||
function netOusdMintForStrategyThreshold() external view returns (uint256); | |||
|
|||
function setOusdMetaStrategy(address _ousdMetaStrategy) external; | |||
function setMetaStrategy(address _strategy) external; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't plan to use this for OETH though right? This is exclusive to OUSDMetStrategy contract. the curve AMO uses mintForStrategy I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It currently is on the OETHVaultAdmin hence the reason for are trying to clean it up.
There may be a better way of doing this. eg
- Move these OUSD specific functions to an OUSD Vault implementation contract
- Change the OUSD strategies to use the more generic functions.
Both sound like a bigger change for another day.
a61b560
to
3f6ed08
Compare
7f5997f
to
7f22eb8
Compare
4583495
to
7e454b0
Compare
358dcf8
to
d8a65ea
Compare
I'd rather do these changes, later after the current OETH vault deploy |
@naddison36 do we want to pair this PR with deployment of some other Vault functionality? So we don't kick off the Vault deploys just for the naming changes? |
Maybe it'b be cool to have a list of PRs that are waiting to join some other more impactful functionality to be deployed |
For the OETH Vault, I'd say it's best to pair with something else. |
Yes agreed, rolling them out for both protocols simultaneously would be nice - in respect of not complicating our environments and mental load. |
This is an optional addition to the PR #1627 that refactors the vaults
It does more more of the items in #1533
Specifically, it covers removing
Ousd
from function names and events.setOusdMetaStrategy
->setMetaStrategy
setNetOusdMintForStrategyThreshold
->setNetMintForStrategyThreshold
OusdMetaStrategyUpdated
->MetaStrategyUpdated
NetOusdMintForStrategyThresholdChanged
->NetMintForStrategyThresholdChanged
The two functions and corresponding events are only used by the governor so breaking the ABI is not such a big deal