OIP-2 Internal dripper and protocol reserves #1203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igin-dollar into DanielVF/oip-2-dripper
DanielVF
changed the title
|
|
* Flipper N-14 Unused import * Moving imports down to the lowest used level
* Flipper N-10 explicit visibilitiy * Flipper N-12 typos
|
@DanielVF should I review this PR? Are we still thinking of deploying this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smooths all yield out and adds a protocol reserve.
By smoothing we improve user experience, and provide hack resistance (since any false yield will be spread out over days, and unavailable in the same block)
Big Picture
The drip rate from the funds reserve is recalculated after every rebase. The rebase rate is based on dividing out the total held in the reserve by the drip duration.
Distribution amount
Fork Simulation
This implements issue #985
And since this is our first Vault Core change since finding this bug, we are adding in #1247.