New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/merge main@bdfb4cc #807
Conversation
Bootstrap doesn't run pa11y yet. So I have to dig into the following report: https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/suites/3813666741/artifacts/94282101; and maybe push a fix to Bootstrap 🤷
|
pa11y is now happy but linkinator is not:
|
Got a discussion with the Orange a11y community and it seems that Edit: Didn't see it but some info here too: |
We begin to have several things ignored by pa11y (see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason on why Bootstrap chose to be more explicit with parameters in functions (e -> event) ?
Other than that, I've checked behaviours for components that are modified and it seems ok for me.
Probably just for readability. |
Get Bootstrap commits from 94c80ff613dce6620591acd7f9930ce8f40c5ed0 (Sept. 7) to bdfb4cc54d29c0c7bcd7944d3c8de2e1cd41bb6c (Sept. 15).
Dear reviewer, please pay attention to twbs/bootstrap@94c80ff which had some impacts on Boosted (-> d85ae3b)