Replace deprecated collection methods in mongodb-backend.js. Fixes #270 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,7 +125,7 @@ MongoDBBackend.prototype = { | |||
| values.forEach(function(value){doc[value]=true;}); | |||
|
|
|||
| // update document | |||
| collection.update(updateParams,{$set:doc},{safe:true,upsert:true},function(err){ | |||
| collection.updateOne(updateParams, {$set:doc}, {w:1, upsert:true}, function(err){ | |||
There was a problem hiding this comment.
Are you sure this update call is intended for only one document and not for many documents?
There was a problem hiding this comment.
why not just use update instead of updateOne?
There was a problem hiding this comment.
update() is deprecated. I strictly followed the advice in https://mongoosejs.com/docs/deprecations.html to resolve the deprecation warnings and to not change the intended functionality. I used updateOne() because, in this case, update() is only updating the first document found.
There was a problem hiding this comment.
Seems like a legit change.
But, don't we need to update mongodb version driver in order to use these new functions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the deprecated collection methods and write concern setting to align with v2.0 and v3.1 of the MongoDB Driver APIs.