Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitized options #504

Merged
merged 14 commits into from Apr 23, 2017
Merged

Sanitized options #504

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2fa99d5
do not start guardian until queue is ready
manast Apr 21, 2017
03cabe5
fixed #503
manast Apr 21, 2017
e9784d3
3.0.0-alpha.2
manast Apr 21, 2017
9e882c3
updated changelog
manast Apr 21, 2017
5271193
fixed #451 and sanitized queue options
manast Apr 21, 2017
2a215fd
assigned lockExtener timer id to variable
manast Apr 21, 2017
515d6f6
use connection string as example, and new for instantiation
manast Apr 22, 2017
80a1507
Capitalize Redis
bradvogel Apr 23, 2017
b9c420a
Use `new` consistently.
bradvogel Apr 23, 2017
c40f649
Remove bad link to bull-ui project.
bradvogel Apr 23, 2017
fe97c07
Expand "Important Notes" section to discuss how stalled jobs work (a …
bradvogel Apr 23, 2017
81639b9
Document new advanced settings.
bradvogel Apr 23, 2017
d5abe9f
Merge pull request #507 from mixmaxhq/document-options
manast Apr 23, 2017
616249c
Merge branch 'v3.0.0' into sanitized-options
manast Apr 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Expand Up @@ -79,9 +79,9 @@ Quick Guide
var Queue = require('bull');

var videoQueue = Queue('video transcoding', {redis: {port: 6379, host: '127.0.0.1'}});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be clearer to use the redis string version here, eg redis://127.0.0.1:6379, since the documentation lists the redisConnectionString as the second option (albeit optional - but some people might not notice that)

var audioQueue = Queue('audio transcoding');
var audioQueue = Queue('audio transcoding', 'redis://127.0.0.1:6379');
var imageQueue = Queue('image transcoding');
var pdfQueue = Queue('pdf transcoding');
var pdfQueue = new Queue('pdf transcoding');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the examples above too, for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. My idea was to show different ways to instantiate in the examples. I could clarify with a comment instead. I like to be able to instantiate without new, but maybe this is not a best practice anymore.


videoQueue.process(function(job, done){

Expand Down